Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OSGi metadata via build #3477

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

swimmesberger
Copy link

@swimmesberger swimmesberger commented Oct 7, 2020

This is analogous to the implementation in square/okhttp#6282

For retrofit there are currently following issues:

  • okhttp/okio is still on a version which do not have OSGi metadata (therefore the test fails)
  • The kotlinx.coroutines (https://github.com/Kotlin/kotlinx.coroutines) stuff is not OSGi compatible, therefore I made those packages optional for now
  • I can't get both "retrofit-converters:guava" and "retrofit-adapters:guava" work together in my test because gradle seems to only copy one of those. It seems as if both of these are defined as project(...) dependencies gradle only adds the first one as an retrievable dependency (maybe a hasdCode/equals conflict?). I have found a similar issue on stackoverflow
  • I can't test moshi/simplexml/wire in the junit test because I haven't found OSGi bundles for those dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant